dahjah/Lime3DS
1
0
Fork 0
mirror of https://github.com/Lime3DS/Lime3DS.git synced 2026-06-07 16:35:14 -06:00
Code Issues Packages Projects Releases Wiki Activity

libretro: better safety on vkDevice feature checks

Browse Source
This commit is contained in:
Eric Warmenhoven 2026-02-23 16:29:56 -05:00 committed by OpenSauce
parent 8fac24d2a4
commit 27c3e0e5c3
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/citra_libretro/libretro_vk.cpp
View File

@ -115,11 +115,24 @@ bool CreateVulkanDevice(struct retro_vulkan_context* context, VkInstance instanc
} }
} }
// Request features we need (these will be OR'd with frontend requirements) // Query actual device features so we only request what's supported
// The Instance class will validate these against actual device capabilities PFN_vkGetPhysicalDeviceFeatures vkGetPhysicalDeviceFeatures =
merged_features.geometryShader = VK_TRUE; // Used for certain rendering effects (PFN_vkGetPhysicalDeviceFeatures)get_instance_proc_addr(instance,
merged_features.logicOp = VK_TRUE; // Used for blending modes "vkGetPhysicalDeviceFeatures");
merged_features.samplerAnisotropy = VK_TRUE; // Used for texture filtering VkPhysicalDeviceFeatures device_features{};
vkGetPhysicalDeviceFeatures(gpu, &device_features);
// Request features we want, gated by actual device support
if (device_features.geometryShader)
merged_features.geometryShader = VK_TRUE;
if (device_features.logicOp)
merged_features.logicOp = VK_TRUE;
if (device_features.samplerAnisotropy)
merged_features.samplerAnisotropy = VK_TRUE;
if (device_features.fragmentStoresAndAtomics)
merged_features.fragmentStoresAndAtomics = VK_TRUE;
if (device_features.shaderClipDistance)
merged_features.shaderClipDistance = VK_TRUE;
// Find queue family with graphics support // Find queue family with graphics support
PFN_vkGetPhysicalDeviceQueueFamilyProperties vkGetPhysicalDeviceQueueFamilyProperties = PFN_vkGetPhysicalDeviceQueueFamilyProperties vkGetPhysicalDeviceQueueFamilyProperties =