dahjah/Lime3DS
1
0
Fork 0
mirror of https://github.com/Lime3DS/Lime3DS.git synced 2026-06-03 05:35:01 -06:00
Code Issues Packages Projects Releases Wiki Activity

android: Prevent crash when editing a slider option with an out of bounds value
Some checks are pending
citra-build / source (push) Waiting to run
Details
citra-build / linux (appimage) (push) Waiting to run
Details
citra-build / linux (fresh) (push) Waiting to run
Details
citra-build / macos (arm64) (push) Waiting to run
Details
citra-build / macos (x86_64) (push) Waiting to run
Details
citra-build / macos-universal (push) Blocked by required conditions
Details
citra-build / windows (msvc) (push) Waiting to run
Details
citra-build / windows (msys2) (push) Waiting to run
Details
citra-build / android (push) Waiting to run
Details
citra-format / clang-format (push) Waiting to run
Details

Browse Source 
Co-authored-by: OpenSauce04 <opensauce04@gmail.com>
This commit is contained in:
DavidRGriswold 2025-09-03 13:16:32 +01:00 committed by OpenSauce04
parent 3ef5bc0bfe
commit 29a77b342b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/android/app/src/main/java/org/citra/citra_emu/features/settings/model/view/SliderSetting.kt
View File

@ -1,4 +1,4 @@
// Copyright Citra Emulator Project / Lime3DS Emulator Project // Copyright Citra Emulator Project / Azahar Emulator Project
// Licensed under GPLv2 or any later version // Licensed under GPLv2 or any later version
// Refer to the license.txt file included. // Refer to the license.txt file included.
@ -10,7 +10,6 @@ import org.citra.citra_emu.features.settings.model.AbstractSetting
import org.citra.citra_emu.features.settings.model.FloatSetting import org.citra.citra_emu.features.settings.model.FloatSetting
import org.citra.citra_emu.features.settings.model.ScaledFloatSetting import org.citra.citra_emu.features.settings.model.ScaledFloatSetting
import org.citra.citra_emu.utils.Log import org.citra.citra_emu.utils.Log
import kotlin.math.roundToInt
class SliderSetting( class SliderSetting(
setting: AbstractSetting?, setting: AbstractSetting?,
@ -27,7 +26,8 @@ class SliderSetting(
val selectedFloat: Float val selectedFloat: Float
get() { get() {
val setting = setting ?: return defaultValue!!.toFloat() val setting = setting ?: return defaultValue!!.toFloat()
return when (setting) {
val ret = when (setting) {
is AbstractIntSetting -> setting.int.toFloat() is AbstractIntSetting -> setting.int.toFloat()
is FloatSetting -> setting.float is FloatSetting -> setting.float
is ScaledFloatSetting -> setting.float is ScaledFloatSetting -> setting.float
@ -36,8 +36,8 @@ class SliderSetting(
-1f -1f
} }
} }
return ret.coerceIn(min.toFloat(), max.toFloat())
} }
/** /**
* Write a value to the backing int. If that int was previously null, * Write a value to the backing int. If that int was previously null,
* initializes a new one and returns it, so it can be added to the Hashmap. * initializes a new one and returns it, so it can be added to the Hashmap.