From 5d6c9cb6bf4b5c33f4ffcf1d730ef9e6e2d08b52 Mon Sep 17 00:00:00 2001 From: adas20 Date: Mon, 28 Jul 2025 11:36:05 -0400 Subject: [PATCH] Moved OnSettingChange after I add or remove selected vals to fix crashing issue. --- .../citra/citra_emu/features/settings/ui/SettingsAdapter.kt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsAdapter.kt b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsAdapter.kt index 96c8b54e8..3cfd67178 100644 --- a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsAdapter.kt +++ b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsAdapter.kt @@ -753,7 +753,6 @@ class SettingsAdapter( val value = it.getValueAt(which) if (value in it.selectedValues && !is_checked) { it.removeSelectedValue(value ?: "") - fragmentView?.onSettingChanged() } else { it.addSelectedValue(value ?: "") } @@ -762,7 +761,6 @@ class SettingsAdapter( is AbstractMultiShortSetting -> { if (is_checked != it.selectValueIndices[which]) { it.removeSelectedValue(it.getValueAt(which)?.toShort() ?: 1) - fragmentView?.onSettingChanged() } else { it.addSelectedValue(it.getValueAt(which)?.toShort() ?: 1) } @@ -771,8 +769,9 @@ class SettingsAdapter( else -> throw IllegalStateException("Unrecognized type used for StringMultiChoiceSetting!") } + fragmentView?.onSettingChanged() fragmentView?.putSetting(setting as AbstractSetting) - //fragmentView.loadSettingsList() + fragmentView.loadSettingsList() //closeDialog() } }