Revert "Fallback to silence when no samples have been captured. (#955)" (#1610)

This reverts commit 1ff5042685.

src/audio_core/cubeb_input.cpp

@@ -144,11 +144,6 @@ Samples CubebInput::Read() {
     while (impl->sample_queue.Pop(queue)) {
         samples.insert(samples.end(), queue.begin(), queue.end());
     }
-
-    if (samples.empty()) {
-        samples = GenerateSilentSamples(parameters);
-    }
-
     return samples;
 }
 

src/audio_core/input.h

@@ -53,22 +53,6 @@ public:
      */
     virtual Samples Read() = 0;
 
-    /**
-     * Generates a buffer of silence.
-     * Takes into account the sample size and signedness of the input.
-     */
-    virtual Samples GenerateSilentSamples(const InputParameters& params) {
-        u8 silent_value = 0x00;
-
-        if (params.sample_size == 8) {
-            silent_value = params.sign == Signedness::Unsigned ? 0x80 : 0x00;
-            return std::vector<u8>(32, silent_value);
-        } else {
-            silent_value = params.sign == Signedness::Unsigned ? 0x80 : 0x00;
-            return std::vector<u8>(64, silent_value);
-        }
-    }
-
 protected:
     InputParameters parameters;
 };

src/audio_core/null_input.h

@@ -30,11 +30,10 @@ public:
     void AdjustSampleRate(u32 sample_rate) override {}
 
     Samples Read() override {
-        return GenerateSilentSamples(parameters);
+        return {};
     }
 
 private:
-    InputParameters parameters;
     bool is_sampling = false;
 };
 

src/audio_core/openal_input.cpp

@@ -108,10 +108,6 @@ Samples OpenALInput::Read() {
         return {};
     }
 
-    if (samples.empty()) {
-        samples = GenerateSilentSamples(parameters);
-    }
-
     return samples;
 }