From e630b0692e76fe4771a90a921ca22124d1b0100e Mon Sep 17 00:00:00 2001 From: Jordan Woyak Date: Sat, 15 Nov 2025 20:25:36 -0600 Subject: [PATCH 1/2] VideoCommon/FramebufferManager: Silence warning: warning: virtual method '~FramebufferManager' is inside a 'final' class and can never be overridden [-Wunnecessary-virtual-specifier] --- Source/Core/VideoCommon/FramebufferManager.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/VideoCommon/FramebufferManager.h b/Source/Core/VideoCommon/FramebufferManager.h index 76546980700..9f10918ac22 100644 --- a/Source/Core/VideoCommon/FramebufferManager.h +++ b/Source/Core/VideoCommon/FramebufferManager.h @@ -49,7 +49,7 @@ class FramebufferManager final { public: FramebufferManager(); - virtual ~FramebufferManager(); + ~FramebufferManager(); // Does not require the framebuffer to be created. Slower than direct queries. static AbstractTextureFormat GetEFBColorFormat(); From 9dea0859eb1ab34cbf8e25d6f99f1bd7dd28b097 Mon Sep 17 00:00:00 2001 From: Jordan Woyak Date: Sat, 15 Nov 2025 20:30:24 -0600 Subject: [PATCH 2/2] Common/BitField: Silence two warnings: warning: definition of implicit copy constructor for 'BitField<2, 2, ColorChannel>' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy] Redundant access specifier has the same accessibility as the previous access specifier. --- Source/Core/Common/BitField.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Source/Core/Common/BitField.h b/Source/Core/Common/BitField.h index 9eef80e0329..35f8871b12b 100644 --- a/Source/Core/Common/BitField.h +++ b/Source/Core/Common/BitField.h @@ -129,6 +129,9 @@ public: // so that we can use this within unions constexpr BitField() = default; + // Allow copy construction. + constexpr BitField(const BitField&) = default; + // We explicitly delete the copy assignment operator here, because the // default copy assignment would copy the full storage value, rather than // just the bits relevant to this particular bit field. @@ -382,7 +385,6 @@ public: constexpr BitFieldArrayIterator(BitFieldArrayIterator&& other) = default; BitFieldArrayIterator& operator=(BitFieldArrayIterator&& other) = default; -public: BitFieldArrayIterator& operator++() { m_index++;