dahjah/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-12-16 04:09:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #14190 from Dentomologist/directiofile_dont_request_delete_access_for_read_only_open

Browse Source 
Windows/DirectIOFile: Don't request DELETE access for read-only Open
This commit is contained in:
Jordan Woyak 2025-11-29 16:23:31 -06:00 committed by GitHub
commit 59d5e25f5f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/Common/DirectIOFile.cpp
View File

@ -86,8 +86,11 @@ bool DirectIOFile::Open(const std::string& path, AccessMode access_mode, OpenMod
else if (access_mode == AccessMode::Write) else if (access_mode == AccessMode::Write)
desired_access = GENERIC_WRITE; desired_access = GENERIC_WRITE;
if (access_mode != AccessMode::Read)
{
// Allow deleting and renaming through our handle. // Allow deleting and renaming through our handle.
desired_access |= DELETE; desired_access |= DELETE;
}
// All sharing is allowed to more closely match default behavior on other OSes. // All sharing is allowed to more closely match default behavior on other OSes.
constexpr DWORD share_mode = FILE_SHARE_DELETE | FILE_SHARE_READ | FILE_SHARE_WRITE; constexpr DWORD share_mode = FILE_SHARE_DELETE | FILE_SHARE_READ | FILE_SHARE_WRITE;