From 8524e725a8e883a0c763b6d791095aba5ff5e5ab Mon Sep 17 00:00:00 2001
From: JosJuice <josjuice@gmail.com>
Date: Sun, 27 Jul 2025 11:37:45 +0200
Subject: [PATCH] Android: Add additional null check in GCAdapter

Just in case, since the documentation says this could be null.
---
 .../dolphinemu/utils/GCAdapter.java           | 75 ++++++++++---------
 1 file changed, 40 insertions(+), 35 deletions(-)

diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/GCAdapter.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/GCAdapter.java
index 12ed20fec7f..b9e67e654f3 100644
--- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/GCAdapter.java
+++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/GCAdapter.java
@@ -142,43 +142,48 @@ public class GCAdapter
     {
       dev = adapterDevice;
     }
-
-    if (dev != null)
+    if (dev == null)
     {
-      usbConnection = manager.openDevice(dev);
-
-      Log.info("GCAdapter: Number of configurations: " + dev.getConfigurationCount());
-      Log.info("GCAdapter: Number of interfaces: " + dev.getInterfaceCount());
-
-      if (dev.getConfigurationCount() > 0 && dev.getInterfaceCount() > 0)
-      {
-        UsbConfiguration conf = dev.getConfiguration(0);
-        usbInterface = conf.getInterface(0);
-        usbConnection.claimInterface(usbInterface, true);
-
-        Log.info("GCAdapter: Number of endpoints: " + usbInterface.getEndpointCount());
-
-        if (usbInterface.getEndpointCount() == 2)
-        {
-          for (int i = 0; i < usbInterface.getEndpointCount(); ++i)
-            if (usbInterface.getEndpoint(i).getDirection() == UsbConstants.USB_DIR_IN)
-              usbIn = usbInterface.getEndpoint(i);
-            else
-              usbOut = usbInterface.getEndpoint(i);
-
-          initAdapter();
-          return true;
-        }
-        else
-        {
-          usbConnection.releaseInterface(usbInterface);
-        }
-      }
-
-      Toast.makeText(DolphinApplication.getAppContext(), R.string.replug_gc_adapter,
-              Toast.LENGTH_LONG).show();
-      usbConnection.close();
+      return false;
     }
+
+    usbConnection = manager.openDevice(dev);
+    if (usbConnection == null)
+    {
+      return false;
+    }
+
+    Log.info("GCAdapter: Number of configurations: " + dev.getConfigurationCount());
+    Log.info("GCAdapter: Number of interfaces: " + dev.getInterfaceCount());
+
+    if (dev.getConfigurationCount() > 0 && dev.getInterfaceCount() > 0)
+    {
+      UsbConfiguration conf = dev.getConfiguration(0);
+      usbInterface = conf.getInterface(0);
+      usbConnection.claimInterface(usbInterface, true);
+
+      Log.info("GCAdapter: Number of endpoints: " + usbInterface.getEndpointCount());
+
+      if (usbInterface.getEndpointCount() == 2)
+      {
+        for (int i = 0; i < usbInterface.getEndpointCount(); ++i)
+          if (usbInterface.getEndpoint(i).getDirection() == UsbConstants.USB_DIR_IN)
+            usbIn = usbInterface.getEndpoint(i);
+          else
+            usbOut = usbInterface.getEndpoint(i);
+
+        initAdapter();
+        return true;
+      }
+      else
+      {
+        usbConnection.releaseInterface(usbInterface);
+      }
+    }
+
+    Toast.makeText(DolphinApplication.getAppContext(), R.string.replug_gc_adapter,
+            Toast.LENGTH_LONG).show();
+    usbConnection.close();
     return false;
   }