dahjah/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-12-16 04:09:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
44,614 Commits 11 Branches 17 Tags 4.3 GiB
6d5e8b9ed8
Commit Graph

32882 Commits

Author SHA1 Message Date
Jordan Woyak
6d5e8b9ed8 Externals: Update mGBA to latest master. 
Co-authored-by: Joshua Vandaële <joshua@vandaele.software>
 2025-11-13 17:03:31 -06:00
Jordan Woyak
c08fda96ca
Merge pull request #14100 from AndrewGDX/master 
Improved stereoscopic 3D settings
 2025-11-12 16:43:21 -06:00
AndrewGDX
113c86f1b4 Improved stereoscopic 3D settings 2025-11-12 12:29:03 +03:00
JMC47
8495e01668
Merge pull request #14096 from jordan-woyak/state-changed-hookable-event 
Core: Make AddOnStateChangedCallback use HookableEvent.
 2025-11-11 20:58:45 -05:00
JMC47
f63796c480
Merge pull request #14071 from iwubcode/avoid_config_framebuffer_manager 
VideoCommon: pass the EFB buffer scale into the FramebufferManager
 2025-11-11 20:58:35 -05:00
JMC47
b8236d4662
Merge pull request #14070 from VampireFlower/master 
Debugger: Ignore bctr when stepping out
 2025-11-11 20:57:45 -05:00
JMC47
c44ea1389a
Merge pull request #13236 from JosJuice/jit-set-msr-on-fallback 
Call JitInterface::UpdateMembase from PowerPC::MSRUpdated
 2025-11-11 20:55:24 -05:00
Jordan Woyak
f51eaf3282
Merge pull request #14052 from jordan-woyak/DirectIOFile 
Common and DiscIO: Introduce a thread safe DirectIOFile and make BlobReader implementations use it.
 2025-11-10 17:29:43 -06:00
JosJuice
cd4902f0ed
Merge pull request #13875 from JosJuice/jitarm64-orr-base-without-mirror 
JitArm64: Add missing ORR pattern in MOVI2RImpl
 2025-11-10 20:16:21 +01:00
Jordan Woyak
a97627e736 Core: Make AddOnStateChangedCallback use HookableEvent. 2025-11-09 16:43:19 -06:00
Admiral H. Curtiss
31ca3bca47
Merge pull request #13956 from jordan-woyak/SA_RESTART 
Main: Add SA_RESTART to sigaction sa_flags.
 2025-11-09 15:30:27 +01:00
Admiral H. Curtiss
02b4b1ece3
Merge pull request #14010 from jordan-woyak/wmreal-iolinux-reopen-on-unplug 
WiimoteReal/IOLinux: Reopen Bluetooth device if it was unplugged between scans.
 2025-11-09 15:03:12 +01:00
Admiral H. Curtiss
c97d2af814
Merge pull request #14022 from TryTwo/fix_balloontip_width 
Settings BalloonTip: Have wordwrap use max width.
 2025-11-09 15:00:19 +01:00
Admiral H. Curtiss
ab2ceb10ae
Merge pull request #14073 from jordan-woyak/convert-dialog-min-size 
DolphinQt: Make disc ConvertDialog have a better minimum size and use QFormLayout.
 2025-11-09 14:57:46 +01:00
Admiral H. Curtiss
6435ee1d20
Merge pull request #14026 from jordan-woyak/move-only-function-fix 
Common/Functional: Fix MoveOnlyFunction from inadvertently creating references from lvalues.
 2025-11-09 14:49:20 +01:00
Admiral H. Curtiss
29e2b0ff01
Merge pull request #14068 from iTrooz/open_folder 
feat(profiles): add "open profiles folder" button + add dropdown button for profile actions
 2025-11-09 14:29:18 +01:00
Admiral H. Curtiss
e197163e9e
Merge pull request #14094 from OatmealDome/mac-nav-list 
SettingsWindow: Set navigation list stylesheet in constructor
 2025-11-09 14:10:39 +01:00
Jordan Woyak
9e2fc7f4dd Common/IOFile: Remove the Duplicate function. The duplicate handles shared a read/write position making them effectively not thread-safe. 2025-11-09 03:08:14 -06:00
Jordan Woyak
239330017c DiscIO: Make all BlobReader implementations use DirectIOFile to make CopyReader functionality thread safe. 2025-11-09 03:08:14 -06:00
Jordan Woyak
b98acb9a37 Common/BitUtils: Add overloads of AsU8Span/AsWritableU8Span that handle conversions from contiguous ranges. 2025-11-09 03:08:14 -06:00
Jordan Woyak
405baed805 Common: Add a DirectIOFile class that allows for copies which are entirely thread safe. 2025-11-09 03:08:14 -06:00
OatmealDome
448329e821
SettingsWindow: Set navigation list stylesheet in constructor 2025-11-09 01:55:52 -05:00
Simonx22
bd93c09e38 CPUThreadConfigCallback: Use maximum value of size_t instead of -1 as default value ConfigChangedCallbackID 
Co-Authored-By: OatmealDome <OatmealDome@users.noreply.github.com>
 2025-11-08 23:23:33 -05:00
OatmealDome
02ad041866
Merge pull request #14086 from Simonx22/android/use-native-analytics 
Android: Use the shared HTTP analytics backend
 2025-11-08 14:03:06 -05:00
OatmealDome
a459dc0d25
Merge pull request #14082 from Simonx22/analytics/reload-on-setting-change 
DolphinAnalytics: Reload backend when config changes
 2025-11-08 14:00:03 -05:00
Simonx22
82f658a28f Android: Use the shared HTTP analytics backend 
We can now route Android analytics through Common::HttpAnalyticsBackend, drop the Volley sender, and keep the JNI layer limited to only transfer metadata since https://bugs.dolphin-emu.org/issues/11772 has been fixed.
 2025-11-08 12:14:40 -05:00
JosJuice
958db7c78c
Merge pull request #14020 from jordan-woyak/string-util-cleanups 
StringUtil: Cleanups and add some character encoding conversion unit tests.
 2025-11-08 17:36:54 +01:00
Simonx22
f67691d564 Config: Use maximum value of size_t instead of -1 as default value in ConfigChangedCallbackID 
Co-authored-by: OatmealDome <julian@oatmealdome.me>
 2025-11-08 11:35:31 -05:00
Simonx22
f9b167d8c6 DolphinAnalytics: Reload backend when config changes 
Co-Authored-By: OatmealDome <julian@oatmealdome.me>
 2025-11-08 11:35:30 -05:00
JosJuice
ba14222a2b
Merge pull request #13939 from Dentomologist/logging_avoid_overwriting_debug_verbosity_in_release_builds 
Logging: Don't overwrite LDEBUG level in Release builds
 2025-11-08 14:47:27 +01:00
Jordan Woyak
5af9bd5e46
Merge pull request #14074 from jordan-woyak/HookableEvent-no-strings 
Common: Remove the string parameters from the HookableEvent interface.
 2025-11-07 16:32:06 -06:00
Jordan Woyak
51cd0a676a
Merge pull request #14079 from Dentomologist/use_asyncworkthread_pushblocking_instead_of_sync_event 
CubebStream: Use WorkQueueThread::PushBlocking instead of sync_event
 2025-11-07 16:31:46 -06:00
Dentomologist
3b97a7bded CubebStream: Use WorkQueueThread::PushBlocking instead of sync_event 
Push and wait on WorkQueueThread items using PushBlocking. Previously we
created a Common::Event sync_event on the caller's stack, called Wait on
it, then had the WorkQueueThread call Set on the sync_event once the
thread was done.

In addition to being simpler the new way avoids a use-after-free that
could happen in convoluted and unlikely yet possible thread scheduling
sequences.

One such case can be triggered as follows:

* Set your audio backend to Cubeb
* In CubebStream::SetVolume set a breakpoint at the call to Wait and at
  the call to cubeb_stream_set_volume.
* Start a game.
* Continue until the Cubeb Worker thread hits the
  cubeb_stream_set_volume breakpoint and Emuthread hits the Wait
  breakpoint, freezing each thread when it hits its breakpoint.
* Unfreeze Cubeb Worker.
* In Event::Set set a breakpoint at the end of the scope containing the
  lock_guard such that the guard has been constructed but not destructed
  when the breakpoint is hit.
* Continue until that breakpoint is hit by Cubeb Worker. If other
  threads hit it first keep going.
* Freeze Cubeb Worker.
* For convenience remove the breakpoint in Event::Set so other threads
  don't trigger it.
* In CubebStream::SetRunning set a breakpoint at the call to Wait.
* Unfreeze Emuthread and continue until the breakpoint is hit.
* In Cubeb Worker go to Event::Set and examine the values of m_mutex's
  member variables. In Visual Studio Debug these are locking_thread_id
  == 0xcccccc01 and ownership_levels == 0xcccccccc. This is the result
  of Visual Studio overwriting the memory used on the stack by
  sync_event in CubebStream::SetVolume with cc bytes to represent
  uninitialized memory on the stack (since that function already
  returned), and then allocating enough memory on the stack when calling
  AudioCommon::SetSoundStreamRunning and then CubebStream::SetRunning
  that it overwrote one byte of the memory formerly occupied by
  locking_thread_id.
* If you unfreeze Cubeb Worker at this point it will trigger the lock
  guard's destructor which will then try to unlock m_mutex. Since
  m_mutex is no longer in scope this is a use-after-free, and in VS
  debug triggers a debug assert due to locking_thread_id not matching
  the current thread id.
 2025-11-07 13:19:18 -08:00
JosJuice
5ed4823ebc
Merge pull request #13858 from LillyJadeKatrin/retroachievements-message-adjustments 
Retroachievements message adjustments
 2025-11-07 16:50:48 +01:00
Jordan Woyak
da6c65bf3b Common: Remove the string parameters from the HookableEvent interface. 2025-11-06 22:34:40 -06:00
Jordan Woyak
5650be6842
Merge pull request #14069 from jordan-woyak/ciface-hookable-event 
InputCommon: Make ControllerInterface RegisterDevicesChangedCallback use Common::HookableEvent.
 2025-11-06 20:06:53 -06:00
LillyJadeKatrin
dd941bed70 Improve Achievements Window message 
Special message on the Achievements window if the token is invalid/expired.
 2025-11-06 20:44:08 -05:00
OatmealDome
852b7d85b2
Merge pull request #14062 from Simonx22/macos-design-fixes 
macOS: UI fixes for dark mode
 2025-11-06 20:20:05 -05:00
LillyJadeKatrin
1ad0a771d9 Delete Invalid RetroAchievements Tokens 2025-11-06 19:42:14 -05:00
LillyJadeKatrin
b1f27b6cfd Added message for bad RetroAchievements token 
Displays a different message at game launch if RetroAchievements fails specifically due to an invalid or expired API token, instructing the player to log back in with the game closed.
 2025-11-06 19:30:22 -05:00
LillyJadeKatrin
4985a1e19b Adjusted mastery message 
Wes from RetroAchievements requested a minor phrasing change to the mastery message.
 2025-11-06 19:30:22 -05:00
Jordan Woyak
a7df85a626 DolphinQt: Make disc ConvertDialog have a better minimum size, use QFormLayout, and clean up the code a bit. 2025-11-06 04:34:07 -06:00
Jordan Woyak
1e144a7cfd CMakeLists: Fix build on Linux with CMake versions less than 3.25. 2025-11-06 02:41:55 -06:00
iwubcode
2f20c12d82 VideoCommon: pass the EFB buffer scale into the FramebufferManager instead of pulling it from config, in the future this will allow us to have multiple framebuffers 2025-11-05 21:52:54 -06:00
Jordan Woyak
ca6d8e1f0b InputCommon: Make ControllerInterface RegisterDevicesChangedCallback use Common::HookableEvent. 2025-11-05 17:12:56 -06:00
Simonx22
cd16ec02bd macOS: UI fixes for dark mode 2025-11-04 15:49:55 -05:00
Jordan Woyak
2170080f53
Merge pull request #14061 from jordan-woyak/config-info-spin-mutex 
ConfigInfo: Cleanups and change mutex to a spin lock.
 2025-11-04 14:09:35 -06:00
Jordan Woyak
7d617878e0
Merge pull request #13626 from jordan-woyak/non-global-hookable-event 
Common: Make HookableEvent use non-static data.
 2025-11-04 13:57:08 -06:00
VampireFlower
294044a02e Debugger: Ignore bctr when stepping out 2025-11-04 11:41:48 -05:00
iTrooz
a99cb008db
feat(profiles): add "open profiles folder" button + add dropdown button for profile actions 
Co-Authored-By: iTrooz <hey@itrooz.fr>
Co-Authored-By: Max Chateau <maxban.chateau@gmail.com>
Co-Authored-By: Damien R. <rodriguezdamien1677@gmail.com>
 2025-11-04 08:09:25 +01:00