From 22b6af685ac8facca487d47f800b948fcb959c8f Mon Sep 17 00:00:00 2001
From: Aarnav Tale <aarnavtale@icloud.com>
Date: Fri, 29 Mar 2024 16:14:35 -0400
Subject: [PATCH] feat: add proper error component

---
 app/components/Code.tsx  | 11 ++++---
 app/components/Error.tsx | 66 ++++++++++++++++++++++++++++++++++++++++
 app/root.tsx             | 40 ++----------------------
 app/routes/_data.tsx     | 25 ++++++++++++++-
 4 files changed, 100 insertions(+), 42 deletions(-)
 create mode 100644 app/components/Error.tsx

diff --git a/app/components/Code.tsx b/app/components/Code.tsx
index 80275bf..0d8fb60 100644
--- a/app/components/Code.tsx
+++ b/app/components/Code.tsx
@@ -1,9 +1,12 @@
-import { type ReactNode } from 'react'
+import clsx from 'clsx'
+import { type HTMLProps } from 'react'
 
-export default function Code({ children }: { readonly children: ReactNode }) {
+type Properties = HTMLProps<HTMLSpanElement>
+
+export default function Code(properties: Properties) {
 	return (
-		<code className='bg-gray-100 dark:bg-zinc-700 p-0.5 rounded-md'>
-			{children}
+		<code className={clsx('bg-gray-100 dark:bg-zinc-700 p-0.5 rounded-md', properties.className)}>
+			{properties.children}
 		</code>
 	)
 }
diff --git a/app/components/Error.tsx b/app/components/Error.tsx
new file mode 100644
index 0000000..01c664f
--- /dev/null
+++ b/app/components/Error.tsx
@@ -0,0 +1,66 @@
+import { Transition } from '@headlessui/react'
+import { ExclamationTriangleIcon } from '@heroicons/react/24/outline'
+import { isRouteErrorResponse, useRouteError } from '@remix-run/react'
+import clsx from 'clsx'
+import { Fragment, useEffect, useState } from 'react'
+
+import Code from './Code'
+
+type Properties = {
+	readonly type?: 'full' | 'embedded';
+}
+
+export function ErrorPopup({ type = 'full' }: Properties) {
+	const [isOpen, setIsOpen] = useState(false)
+	const error = useRouteError()
+	const routing = isRouteErrorResponse(error)
+	const message = (error instanceof Error ? error.message : 'An unexpected error occurred')
+	console.error(error)
+
+	// Debounce the error modal so it doesn't show up for a split second
+	// when the user navigates to a new page.
+	useEffect(() => {
+		setTimeout(() => {
+			setIsOpen(true)
+		}, 150)
+	}, [])
+
+	return (
+		<Transition as={Fragment} show={isOpen}>
+			<Transition.Child
+				as={Fragment}
+				enter='ease-out duration-150'
+				enterFrom='opacity-0 scale-95'
+				enterTo='opacity-100 scale-100'
+			>
+
+				<div className={clsx(
+					'flex items-center justify-center overflow-clip',
+					type === 'full' ? 'min-h-screen' : 'mt-24'
+				)}
+				>
+					<div className={clsx(
+						'flex flex-col items-center justify-center space-y-2 w-full sm:w-1/2 xl:w-1/3',
+						'bg-white dark:bg-zinc-800 rounded-lg py-8 px-4 md:px-16',
+						'border border-gray-200 dark:border-zinc-700 text-center'
+					)}
+					>
+						<ExclamationTriangleIcon className='w-12 h-12 text-red-500'/>
+						<h1 className='text-2xl font-semibold text-gray-800 dark:text-gray-100'>
+							{routing ? error.status : 'Error'}
+						</h1>
+						{routing ? (
+							<p className='text-gray-500 dark:text-gray-400'>
+								{error.statusText}
+							</p>
+						) : (
+							<Code className='text-sm'>
+								{message}
+							</Code>
+						)}
+					</div>
+				</div>
+			</Transition.Child>
+		</Transition>
+	)
+}
diff --git a/app/root.tsx b/app/root.tsx
index 5fc53a3..9f5a19c 100644
--- a/app/root.tsx
+++ b/app/root.tsx
@@ -1,17 +1,13 @@
-import { ExclamationTriangleIcon, QuestionMarkCircleIcon } from '@heroicons/react/24/outline'
 import type { LinksFunction, MetaFunction } from '@remix-run/node'
 import {
-	isRouteErrorResponse,
 	Links,
 	Meta,
 	Outlet,
 	Scripts,
-	ScrollRestoration,
-	useRouteError
+	ScrollRestoration
 } from '@remix-run/react'
-import clsx from 'clsx'
 
-import Code from '~/components/Code'
+import { ErrorPopup } from '~/components/Error'
 import Toaster from '~/components/Toaster'
 import stylesheet from '~/tailwind.css?url'
 import { getContext } from '~/utils/config'
@@ -68,37 +64,7 @@ export function Layout({ children }: { readonly children: React.ReactNode }) {
 }
 
 export function ErrorBoundary() {
-	const error = useRouteError()
-	const routing = isRouteErrorResponse(error)
-	const message = (error instanceof Error ? error.message : 'An unexpected error occurred')
-	return (
-		<div className='flex min-h-screen items-center justify-center'>
-			<div className={clsx(
-				'w-1/3 border p-4 rounded-lg flex flex-col items-center text-center',
-				routing ? 'gap-2' : 'gap-4'
-			)}
-			>
-				{routing ? (
-					<>
-						<QuestionMarkCircleIcon className='text-gray-500 w-14 h-14'/>
-						<h1 className='text-2xl font-bold'>{error.status}</h1>
-						<p className='opacity-50 text-sm'>{error.statusText}</p>
-					</>
-				) : (
-					<>
-						<ExclamationTriangleIcon className='text-red-500 w-14 h-14'/>
-						<h1 className='text-2xl font-bold'>Error</h1>
-						<Code>
-							{message}
-						</Code>
-						<p className='opacity-50 text-sm mt-4'>
-							If you are the administrator of this site, please check your logs for information.
-						</p>
-					</>
-				)}
-			</div>
-		</div>
-	)
+	return <ErrorPopup/>
 }
 
 export default function App() {
diff --git a/app/routes/_data.tsx b/app/routes/_data.tsx
index 0bea678..8f2d9a9 100644
--- a/app/routes/_data.tsx
+++ b/app/routes/_data.tsx
@@ -1,7 +1,8 @@
 import { Cog8ToothIcon, CpuChipIcon, GlobeAltIcon, LockClosedIcon, ServerStackIcon, UsersIcon } from '@heroicons/react/24/outline'
 import { type LoaderFunctionArgs, redirect } from '@remix-run/node'
-import { Outlet } from '@remix-run/react'
+import { Outlet, useRouteError } from '@remix-run/react'
 
+import { ErrorPopup } from '~/components/Error'
 import TabLink from '~/components/TabLink'
 import { HeadscaleError, pull } from '~/utils/headscale'
 import { destroySession, getSession } from '~/utils/sessions'
@@ -61,3 +62,25 @@ export default function Layout() {
 	)
 }
 
+export function ErrorBoundary() {
+	return (
+		<>
+			<header className='mb-16 bg-gray-800 text-white dark:bg-gray-700'>
+				<nav className='container mx-auto'>
+					<div className='flex items-center gap-x-2 mb-8 pt-4'>
+						<CpuChipIcon className='w-8 h-8'/>
+						<h1 className='text-2xl'>Headplane</h1>
+					</div>
+					<div className='flex items-center gap-x-4'>
+						<TabLink to='/machines' name='Machines' icon={<ServerStackIcon className='w-5 h-5'/>}/>
+						<TabLink to='/users' name='Users' icon={<UsersIcon className='w-5 h-5'/>}/>
+						<TabLink to='/acls' name='Access Control' icon={<LockClosedIcon className='w-5 h-5'/>}/>
+						<TabLink to='/dns' name='DNS' icon={<GlobeAltIcon className='w-5 h-5'/>}/>
+						<TabLink to='/settings' name='Settings' icon={<Cog8ToothIcon className='w-5 h-5'/>}/>
+					</div>
+				</nav>
+			</header>
+			<ErrorPopup type='embedded'/>
+		</>
+	)
+}