dahjah/headplane
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

feat: do partial client method validation

Browse Source
This commit is contained in:
Aarnav Tale 2025-01-06 08:19:15 +05:30
parent fc5028994a
commit 55c832c536
No known key found for this signature in database
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/utils/oidc.ts
View File

@ -2,7 +2,8 @@ import { redirect } from 'react-router';
import {
authorizationCodeGrantRequest,
calculatePKCECodeChallenge,
type Client,
Client,
ClientAuthenticationMethod,
discoveryRequest,
generateRandomCodeVerifier,
generateRandomNonce,
@ -34,10 +35,12 @@ export async function startOidc(oidc: OidcConfig, req: Request) {
});
}
// TODO: Properly validate the method is a valid type
const method = oidc.method as ClientAuthenticationMethod;
const issuerUrl = new URL(oidc.issuer);
const oidcClient = {
client_id: oidc.client,
token_endpoint_auth_method: oidc.method,
token_endpoint_auth_method: method
} satisfies Client;
const response = await discoveryRequest(issuerUrl);
@ -88,11 +91,13 @@ export async function finishOidc(oidc: OidcConfig, req: Request) {
});
}
// TODO: Properly validate the method is a valid type
const method = oidc.method as ClientAuthenticationMethod;
const issuerUrl = new URL(oidc.issuer);
const oidcClient = {
client_id: oidc.client,
client_secret: oidc.secret,
token_endpoint_auth_method: oidc.method,
token_endpoint_auth_method: method,
} satisfies Client;
const response = await discoveryRequest(issuerUrl);