From 306edddf0835ab37ccd1e31f22fad7f2fffb8c2c Mon Sep 17 00:00:00 2001 From: Kravickas Date: Mon, 30 Mar 2026 02:51:34 +0200 Subject: [PATCH] ui9 Removed unnecessary addition of 10 to browser height calculation and added comments for clarity. --- rpcs3/rpcs3qt/update_manager.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/rpcs3/rpcs3qt/update_manager.cpp b/rpcs3/rpcs3qt/update_manager.cpp index 01ab77ab37..6ad460d29d 100644 --- a/rpcs3/rpcs3qt/update_manager.cpp +++ b/rpcs3/rpcs3qt/update_manager.cpp @@ -447,19 +447,19 @@ void update_manager::update(bool auto_accept) changelog_browser->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff); changelog_browser->setHtml(QStringLiteral("

%0

%1").arg(tr("Changelog:"), changelog_html)); - // Measure height for 6 entries directly + // Measure height for 6 entries directly. int browser_height; if (changelog_count > 6) { // Temporarily render only 6 entries to get exact pixel height changelog_browser->setHtml(QStringLiteral("

%0

%1").arg(tr("Changelog:"), changelog_html_capped)); - browser_height = static_cast(changelog_browser->document()->size().height()) + 10; + browser_height = static_cast(changelog_browser->document()->size().height()); changelog_browser->setHtml(QStringLiteral("

%0

%1").arg(tr("Changelog:"), changelog_html)); } else { - browser_height = static_cast(changelog_browser->document()->size().height()) + 10; + browser_height = static_cast(changelog_browser->document()->size().height()); } changelog_browser->setFixedSize(500, browser_height); @@ -472,6 +472,9 @@ void update_manager::update(bool auto_accept) grid->addWidget(toggle_btn, row++, 0, 1, cols); grid->addWidget(changelog_browser, row++, 0, 1, cols); + // Pre-size dialog so it doesn't resize when toggling + mb.setMinimumWidth(540); + QObject::connect(toggle_btn, &QPushButton::clicked, [changelog_browser, toggle_btn, &mb, show_text, hide_text]() { const bool becoming_visible = !changelog_browser->isVisible();