dahjah/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2026-06-07 07:35:02 -06:00
Code Issues Packages Projects Releases Wiki Activity

cellMusic: Fix shuffle always producing the same order

Browse Source 
The shuffle in step_track() used std::default_random_engine with a
default (fixed) seed, causing the playlist to be 'shuffled' into the
same deterministic order every time. Use std::random_device to seed the
engine so each shuffle produces a genuinely random order.

Fixes #18672
This commit is contained in:
Edwin Jarvis 2026-05-11 15:23:37 +08:00
parent 6b5a2f781a
commit 544ba3bf20
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
rpcs3/Emu/Cell/Modules/cellMusicSelectionContext.cpp
View File

@ -362,7 +362,8 @@ u32 music_selection_context::step_track(bool next)
{ {
// We reached the first or last track again. Let's shuffle! // We reached the first or last track again. Let's shuffle!
cellMusicSelectionContext.notice("step_track: Shuffling playlist..."); cellMusicSelectionContext.notice("step_track: Shuffling playlist...");
auto engine = std::default_random_engine{}; std::random_device rd;
auto engine = std::default_random_engine{rd()};
std::shuffle(std::begin(playlist), std::end(playlist), engine); std::shuffle(std::begin(playlist), std::end(playlist), engine);
} }
} }