dahjah/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2026-07-10 01:44:41 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove splat + perm_only & safer single source

Browse Source 
Removed the ARM `is_single_splat && perm_only` path due to it being too niche.

Changed the single source logic to use a `std::optional` rather than a (always set) value + boolean.
This commit is contained in:
Walter 2026-06-26 18:01:51 +10:00
parent d58de9c8c9
commit 7f66f2d8c7
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
rpcs3/Emu/Cell/SPULLVMRecompiler.cpp
View File

@ -7081,7 +7081,7 @@ public:
const auto known_idx = get_known_bits(c); const auto known_idx = get_known_bits(c);
const bool perm_only = known_idx.Zero[7]; const bool perm_only = known_idx.Zero[7];
const bool perm_or_zero_only = known_idx.Zero[6]; const bool perm_or_zero_only = known_idx.Zero[6];
const bool is_single_source = known_idx.extractBits(1, 4).isConstant() || (op.ra == op.rb && !m_interp_magn); const bool idx_selects_single = known_idx.extractBits(1, 4).isConstant();
const auto a = get_vr<u8[16]>(op.ra); const auto a = get_vr<u8[16]>(op.ra);
const auto b = get_vr<u8[16]>(op.rb); const auto b = get_vr<u8[16]>(op.rb);
@ -7127,7 +7127,10 @@ public:
} }
// When single source, either indicated by KnownBits or both are the same // When single source, either indicated by KnownBits or both are the same
const auto only_src = known_idx.One[4] ? bv : av; const std::optional<value_t<u8[16]>> single_src = (idx_selects_single || (op.ra == op.rb && !m_interp_magn))
? std::make_optional(known_idx.One[4] ? bv : av)
: std::nullopt;
const bool only_src_is_splat = known_idx.One[4] ? b_is_splat : a_is_splat; const bool only_src_is_splat = known_idx.One[4] ? b_is_splat : a_is_splat;
// Can combine the special index constants + splat selection into one LUT // Can combine the special index constants + splat selection into one LUT
@ -7140,13 +7143,9 @@ public:
// NOTE: LLVM doesn't emit BCAX (llvm-project/issues/200699) // NOTE: LLVM doesn't emit BCAX (llvm-project/issues/200699)
// Verify if `(x ^ 0x0F) & 0x?F` is reassociated when upstreamed // Verify if `(x ^ 0x0F) & 0x?F` is reassociated when upstreamed
if (is_single_source) if (single_src)
{ {
if (only_src_is_splat && perm_only) const auto only_src = single_src.value();
{
set_vr(op.rt4, only_src);
return;
}
if (only_src_is_splat && perm_or_zero_only) if (only_src_is_splat && perm_or_zero_only)
{ {
@ -7206,15 +7205,15 @@ public:
bool shuf_zero_when_msb = false; bool shuf_zero_when_msb = false;
value_t<u8[16]> ab_shuf; value_t<u8[16]> ab_shuf;
if (is_single_source) if (single_src)
{ {
if (only_src_is_splat) if (only_src_is_splat)
{ {
ab_shuf = only_src; ab_shuf = single_src.value();
} }
else else
{ {
ab_shuf = eval(pshufb(only_src, cv)); ab_shuf = eval(pshufb(single_src.value(), cv));
shuf_zero_when_msb = true; shuf_zero_when_msb = true;
} }
} }