dahjah/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2026-06-01 12:15:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

rsx: Fix up the framebuffer width if the pitch fits scissor but not the clip width

Browse Source
This commit is contained in:
kd-11 2023-04-24 22:53:30 +03:00 committed by kd-11
parent 3f066cca4a
commit 7feb13671a
1 changed files with 43 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
rpcs3/Emu/RSX/RSXThread.cpp
View File

@ -1519,37 +1519,55 @@ namespace rsx
u16 corrected_width = umax; u16 corrected_width = umax;
std::vector<u32*> pitch_fixups; std::vector<u32*> pitch_fixups;
if (!depth_buffer_unused && if (!depth_buffer_unused)
layout.zeta_pitch < minimum_zeta_pitch)
{ {
if (layout.zeta_pitch > 64) if (layout.zeta_pitch < minimum_zeta_pitch)
{ {
corrected_width = layout.zeta_pitch / depth_texel_size; // Observed in CoD3 where the depth buffer is clearly misconfigured.
layout.zeta_pitch = depth_texel_size; if (layout.zeta_pitch > 64)
pitch_fixups.push_back(&layout.zeta_pitch);
}
else
{
rsx_log.warning("Misconfigured surface could not fit a depth buffer. Dropping.");
layout.zeta_address = 0;
}
}
for (const auto& index : rsx::utility::get_rtt_indexes(layout.target))
{
if (!color_buffer_unused &&
layout.color_pitch[index] < minimum_color_pitch)
{
if (layout.color_pitch[index] > 64)
{ {
corrected_width = std::min<u16>(corrected_width, layout.color_pitch[index] / color_texel_size); corrected_width = layout.zeta_pitch / depth_texel_size;
layout.color_pitch[index] = color_texel_size; layout.zeta_pitch = depth_texel_size;
pitch_fixups.push_back(&layout.color_pitch[index]); pitch_fixups.push_back(&layout.zeta_pitch);
} }
else else
{ {
rsx_log.warning("Misconfigured surface could not fit color buffer %d. Dropping.", index); rsx_log.warning("Misconfigured surface could not fit a depth buffer. Dropping.");
layout.color_addresses[index] = 0; layout.zeta_address = 0;
}
}
else if (layout.width * depth_texel_size > layout.zeta_pitch)
{
// This is ok, misconfigured raster dimensions, but we're only writing the pitch as determined by the scissor
corrected_width = layout.zeta_pitch / depth_texel_size;
}
}
if (!color_buffer_unused)
{
for (const auto& index : rsx::utility::get_rtt_indexes(layout.target))
{
if (layout.color_pitch[index] < minimum_color_pitch)
{
if (layout.color_pitch[index] > 64)
{
corrected_width = std::min<u16>(corrected_width, layout.color_pitch[index] / color_texel_size);
layout.color_pitch[index] = color_texel_size;
pitch_fixups.push_back(&layout.color_pitch[index]);
}
else
{
rsx_log.warning("Misconfigured surface could not fit color buffer %d. Dropping.", index);
layout.color_addresses[index] = 0;
}
continue;
}
if (layout.width * color_texel_size > layout.color_pitch[index])
{
// This is ok, misconfigured raster dimensions, but we're only writing the pitch as determined by the scissor
corrected_width = std::min<u16>(corrected_width, layout.color_pitch[index] / color_texel_size);
} }
} }
} }