dahjah/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2026-06-01 12:15:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

SPU DisAsm: Disable unlikely float representations

Browse Source
This commit is contained in:
Elad 2025-12-10 09:48:18 +02:00
parent cc1b4c8fd1
commit bbd91dad92
2 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rpcs3/Emu/Cell/PPUDisAsm.cpp
View File

@ -330,7 +330,7 @@ void comment_constant(std::string& last_opcode, u64 value, bool print_float = fa
// Comment constant formation // Comment constant formation
fmt::append(last_opcode, " #0x%xh", value); fmt::append(last_opcode, " #0x%xh", value);
if (print_float && ((value >> 31) <= 1u || (value >> 31) == 0x1'ffff'ffffu)) if (print_float && ((value >> 31) <= 1u || (value >> 31) == 0x1'ffff'ffffu) && (value > 0x3fffff && (value << 32 >> 32) < 0xffc00000))
{ {
const f32 float_val = std::bit_cast<f32>(static_cast<u32>(value)); const f32 float_val = std::bit_cast<f32>(static_cast<u32>(value));

24
rpcs3/Emu/Cell/SPUDisAsm.h
View File

@ -903,8 +903,14 @@ public:
if (auto [is_const, value] = try_get_const_equal_value_array<u32>(+op.ra); is_const) if (auto [is_const, value] = try_get_const_equal_value_array<u32>(+op.ra); is_const)
{ {
if (value % 0x200 != 0)
{
// si10 is overwritten - likely an analysis mistake
return;
}
// Comment constant formation // Comment constant formation
comment_constant(last_opcode, value | static_cast<u32>(op.si10)); comment_constant(last_opcode, value | static_cast<u32>(op.si10), false);
} }
} }
void ORHI(spu_opcode_t op) void ORHI(spu_opcode_t op)
@ -941,8 +947,14 @@ public:
if (auto [is_const, value] = try_get_const_equal_value_array<u32>(op.ra); is_const) if (auto [is_const, value] = try_get_const_equal_value_array<u32>(op.ra); is_const)
{ {
if (value % 0x200 != 0)
{
// si10 is overwritten - likely an analysis mistake
return;
}
// Comment constant formation // Comment constant formation
comment_constant(last_opcode, value + static_cast<u32>(op.si10)); comment_constant(last_opcode, value + static_cast<u32>(op.si10), false);
} }
} }
void AHI(spu_opcode_t op) void AHI(spu_opcode_t op)
@ -963,8 +975,14 @@ public:
if (auto [is_const, value] = try_get_const_equal_value_array<u32>(op.ra); is_const) if (auto [is_const, value] = try_get_const_equal_value_array<u32>(op.ra); is_const)
{ {
if (value % 0x200 != 0)
{
// si10 is overwritten - likely an analysis mistake
return;
}
// Comment constant formation // Comment constant formation
comment_constant(last_opcode, value ^ static_cast<u32>(op.si10)); comment_constant(last_opcode, value ^ static_cast<u32>(op.si10), false);
} }
} }
void XORHI(spu_opcode_t op) void XORHI(spu_opcode_t op)