dahjah/rpcs3
1
0
Fork 0
mirror of https://github.com/RPCS3/rpcs3.git synced 2026-06-01 12:15:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Qt: log error cause on shortcut icon creation

Browse Source
This commit is contained in:
Megamouse 2024-06-11 20:35:07 +02:00
parent 461862be46
commit cc19685207
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
rpcs3/rpcs3qt/shortcut_utils.cpp
View File

@ -22,6 +22,7 @@
#endif #endif
#include <QFile> #include <QFile>
#include <QImageWriter>
#include <QPixmap> #include <QPixmap>
#include <QStandardPaths> #include <QStandardPaths>
@ -49,13 +50,14 @@ namespace gui::utils
QFile icon_file(QString::fromStdString(target_icon_path)); QFile icon_file(QString::fromStdString(target_icon_path));
if (!icon_file.open(QFile::OpenModeFlag::ReadWrite | QFile::OpenModeFlag::Truncate)) if (!icon_file.open(QFile::OpenModeFlag::ReadWrite | QFile::OpenModeFlag::Truncate))
{ {
sys_log.error("Failed to create icon file: %s", target_icon_path); sys_log.error("Failed to create icon file '%s': %s", target_icon_path, icon_file.errorString());
return false; return false;
} }
if (!icon.save(&icon_file, fmt::to_upper(extension).c_str())) // Use QImageWriter instead of QPixmap::save in order to be able to log errors
if (QImageWriter writer(&icon_file, fmt::to_upper(extension).c_str()); !writer.write(icon.toImage()))
{ {
sys_log.error("Failed to write icon file: %s", target_icon_path); sys_log.error("Failed to write icon file '%s': %s", target_icon_path, writer.errorString());
return false; return false;
} }
@ -230,8 +232,8 @@ namespace gui::utils
fmt::append(link_path, "/%s.app", simple_name); fmt::append(link_path, "/%s.app", simple_name);
const std::string contents_dir = link_path + "/Contents/"; const std::string contents_dir = link_path + "/Contents/";
const std::string macos_dir = contents_dir + "/MacOS/"; const std::string macos_dir = contents_dir + "MacOS/";
const std::string resources_dir = contents_dir + "/Resources/"; const std::string resources_dir = contents_dir + "Resources/";
if (!fs::create_path(contents_dir) || !fs::create_path(macos_dir) || !fs::create_path(resources_dir)) if (!fs::create_path(contents_dir) || !fs::create_path(macos_dir) || !fs::create_path(resources_dir))
{ {