From dc382f4fdb82357a5a23e6d9882397a3a05bae45 Mon Sep 17 00:00:00 2001 From: Megamouse Date: Tue, 30 Jun 2026 19:53:22 +0200 Subject: [PATCH] Fix OOB in Dimensions --- rpcs3/Emu/Io/Dimensions.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/rpcs3/Emu/Io/Dimensions.cpp b/rpcs3/Emu/Io/Dimensions.cpp index fb3327779d..179be8ef3c 100644 --- a/rpcs3/Emu/Io/Dimensions.cpp +++ b/rpcs3/Emu/Io/Dimensions.cpp @@ -530,11 +530,10 @@ bool dimensions_toypad::create_blank_character(std::array& buf, std::array dimensions_toypad::pwd_generate(const std::array& uid) { - std::vector pwd_calc = {PWD_CONSTANT.begin(), PWD_CONSTANT.end() - 1}; - for (u8 i = 0; i < uid.size(); i++) - { - pwd_calc.insert(pwd_calc.begin() + i, uid[i]); - } + std::vector pwd_calc; + pwd_calc.reserve(uid.size() + PWD_CONSTANT.size()); + pwd_calc.insert(pwd_calc.end(), uid.begin(), uid.end()); + pwd_calc.insert(pwd_calc.end(), PWD_CONSTANT.begin(), PWD_CONSTANT.end()); return dimensions_randomize(pwd_calc, 8); }