mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-27 13:25:23 -06:00
Merge branch 'main' into user_and_settings
This commit is contained in:
commit
46b51b968f
77
.github/ISSUE_TEMPLATE/rfc.yaml
vendored
Normal file
77
.github/ISSUE_TEMPLATE/rfc.yaml
vendored
Normal file
@ -0,0 +1,77 @@
|
||||
# SPDX-FileCopyrightText: Copyright 2026 shadPS4 Emulator Project
|
||||
# SPDX-License-Identifier: GPL-2.0-or-later
|
||||
# Docs - https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
|
||||
name: Request For Comments (RFC)
|
||||
description: Ask for feedback on major architectural changes or design choices
|
||||
title: "[RFC]: "
|
||||
labels: ["RFC"]
|
||||
|
||||
body:
|
||||
- type: markdown
|
||||
attributes:
|
||||
value: |
|
||||
## Important: Read First
|
||||
|
||||
RFCs are for major architectural changes, design direction, or changes that benefit from structured discussion before merge.
|
||||
|
||||
Please make an effort to search for an existing RFC or issue before opening a new one.
|
||||
|
||||
- type: checkboxes
|
||||
id: checklist
|
||||
attributes:
|
||||
label: Checklist
|
||||
options:
|
||||
- label: I have searched for a similar RFC or issue in this repository and did not find one.
|
||||
required: true
|
||||
|
||||
- type: textarea
|
||||
id: motivation
|
||||
attributes:
|
||||
label: Motivation
|
||||
description: |
|
||||
Explain the problem this RFC is trying to solve.
|
||||
|
||||
Describe why the current design is insufficient and why this change is worth discussing now.
|
||||
validations:
|
||||
required: true
|
||||
|
||||
- type: textarea
|
||||
id: proposed_change
|
||||
attributes:
|
||||
label: Proposed Change
|
||||
description: |
|
||||
Describe the proposed change in enough detail for maintainers and contributors to evaluate it.
|
||||
|
||||
Include the high-level design, affected areas, and any important constraints.
|
||||
validations:
|
||||
required: true
|
||||
|
||||
- type: textarea
|
||||
id: feedback_period
|
||||
attributes:
|
||||
label: Feedback Period
|
||||
description: |
|
||||
State the intended review window for this RFC.
|
||||
|
||||
Example: one week, two weeks, or until specific maintainers have reviewed it.
|
||||
placeholder: "Example: 1 week"
|
||||
validations:
|
||||
required: false
|
||||
|
||||
- type: textarea
|
||||
id: cc_list
|
||||
attributes:
|
||||
label: CC List
|
||||
description: |
|
||||
List any maintainers or contributors you want to explicitly notify for feedback.
|
||||
validations:
|
||||
required: false
|
||||
|
||||
- type: textarea
|
||||
id: additional_context
|
||||
attributes:
|
||||
label: Any Other Things
|
||||
description: |
|
||||
Add any other relevant context, tradeoffs, diagrams, migration notes, or links to related work.
|
||||
validations:
|
||||
required: false
|
||||
@ -407,6 +407,13 @@ void FsrPass::ResizeAndInvalidate(u32 width, u32 height) {
|
||||
void FsrPass::CreateImages(Img& img) const {
|
||||
img.dirty = false;
|
||||
|
||||
// Destroy previous resources before re-creating at new size.
|
||||
// Views first, then images (views reference the images).
|
||||
img.intermediary_image_view.reset();
|
||||
img.output_image_view.reset();
|
||||
img.intermediary_image.Destroy();
|
||||
img.output_image.Destroy();
|
||||
|
||||
vk::ImageCreateInfo image_create_info{
|
||||
.imageType = vk::ImageType::e2D,
|
||||
.format = vk::Format::eR16G16B16A16Sfloat,
|
||||
|
||||
@ -82,6 +82,14 @@ UniqueImage::~UniqueImage() {
|
||||
}
|
||||
}
|
||||
|
||||
void UniqueImage::Destroy() {
|
||||
if (image) {
|
||||
vmaDestroyImage(allocator, image, allocation);
|
||||
image = vk::Image{};
|
||||
allocation = {};
|
||||
}
|
||||
}
|
||||
|
||||
void UniqueImage::Create(const vk::ImageCreateInfo& image_ci) {
|
||||
this->image_ci = image_ci;
|
||||
ASSERT(!image);
|
||||
|
||||
@ -59,6 +59,8 @@ struct UniqueImage {
|
||||
|
||||
void Create(const vk::ImageCreateInfo& image_ci);
|
||||
|
||||
void Destroy();
|
||||
|
||||
operator vk::Image() const {
|
||||
return image;
|
||||
}
|
||||
|
||||
Loading…
Reference in New Issue
Block a user