dahjah/shadPS4
1
0
Fork 0
mirror of https://github.com/shadps4-emu/shadPS4.git synced 2026-06-11 20:25:01 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add comments for BC4 and BC5 sRGB format handling

Browse Source 
Added comments explaining the absence of sRGB variants for BC4 and BC5 formats in Vulkan.
This commit is contained in:
Hog 2026-06-07 15:03:22 +01:00 committed by GitHub
parent f47efc3200
commit 65cb2987ec
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/video_core/renderer_vulkan/liverpool_to_vk.cpp
View File

@ -722,11 +722,17 @@ std::span<const SurfaceFormatInfo> SurfaceFormats() {
vk::Format::eBc4UnormBlock),
CreateSurfaceFormatInfo(AmdGpu::DataFormat::FormatBc4, AmdGpu::NumberFormat::Snorm,
vk::Format::eBc4SnormBlock),
// BC4 has no sRGB variant in Vulkan; treat as Unorm (single-channel, not color data)
CreateSurfaceFormatInfo(AmdGpu::DataFormat::FormatBc4, AmdGpu::NumberFormat::Srgb,
vk::Format::eBc4UnormBlock),
// BC5
CreateSurfaceFormatInfo(AmdGpu::DataFormat::FormatBc5, AmdGpu::NumberFormat::Unorm,
vk::Format::eBc5UnormBlock),
CreateSurfaceFormatInfo(AmdGpu::DataFormat::FormatBc5, AmdGpu::NumberFormat::Snorm,
vk::Format::eBc5SnormBlock),
// BC5 has no sRGB variant in Vulkan; treat as Unorm (two-channel normal map, not color data)
CreateSurfaceFormatInfo(AmdGpu::DataFormat::FormatBc5, AmdGpu::NumberFormat::Srgb,
vk::Format::eBc5UnormBlock),
// BC6
CreateSurfaceFormatInfo(AmdGpu::DataFormat::FormatBc6, AmdGpu::NumberFormat::Unorm,
vk::Format::eBc6HUfloatBlock),