Only queue image downloads if the image address is greater than zero. (#3446)
Some checks are pending
Build and Release / reuse (push) Waiting to run
Build and Release / clang-format (push) Waiting to run
Build and Release / get-info (push) Waiting to run
Build and Release / windows-sdl (push) Blocked by required conditions
Build and Release / windows-qt (push) Blocked by required conditions
Build and Release / macos-sdl (push) Blocked by required conditions
Build and Release / macos-qt (push) Blocked by required conditions
Build and Release / linux-sdl (push) Blocked by required conditions
Build and Release / linux-qt (push) Blocked by required conditions
Build and Release / linux-sdl-gcc (push) Blocked by required conditions
Build and Release / linux-qt-gcc (push) Blocked by required conditions
Build and Release / pre-release (push) Blocked by required conditions

If the image address is zero, that means we're trying to download a null image, which causes other issues down the line.
This commit is contained in:
Stephen Miller 2025-08-23 06:18:40 -05:00 committed by GitHub
parent 788228c0f3
commit 7165772e9b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -538,7 +538,8 @@ ImageView& TextureCache::FindTexture(ImageId image_id, const BaseDesc& desc) {
Image& image = slot_images[image_id];
if (desc.type == BindingType::Storage) {
image.flags |= ImageFlagBits::GpuModified;
if (Config::readbackLinearImages() && !image.info.props.is_tiled) {
if (Config::readbackLinearImages() && !image.info.props.is_tiled &&
image.info.guest_address != 0) {
download_images.emplace(image_id);
}
}