dahjah/shadPS4
1
0
Fork 0
mirror of https://github.com/shadps4-emu/shadPS4.git synced 2026-04-29 23:41:19 -06:00
Code Issues Packages Projects Releases Wiki Activity

Save fixes VIIIIX (#4315)

Browse Source 
* fix issue with concurrent writes , this fix racing with permission denied

* optimize

* fixup
This commit is contained in:
georgemoralis 2026-04-24 23:16:15 +03:00 committed by GitHub
parent f710074500
commit 737d23b28b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/core/libraries/save_data/save_backup.cpp
View File

@ -10,6 +10,7 @@
#include "save_backup.h"
#include "save_instance.h"
#include "common/io_file.h"
#include "common/logging/formatter.h"
#include "common/logging/log.h"
#include "common/polyfill_thread.h"
@ -24,6 +25,41 @@ namespace fs = std::filesystem;
namespace Libraries::SaveData::Backup {
static void CopyShareReadWrite(const std::filesystem::path& from, const std::filesystem::path& to) {
std::error_code ec;
if (fs::is_directory(from, ec)) {
fs::create_directories(to, ec);
for (const auto& entry : fs::directory_iterator(from)) {
CopyShareReadWrite(entry.path(), to / entry.path().filename());
}
return;
}
Common::FS::IOFile src{from, Common::FS::FileAccessMode::Read, Common::FS::FileType::BinaryFile,
Common::FS::FileShareFlag::ShareReadWrite};
if (!src.IsOpen()) {
LOG_ERROR(Lib_SaveData, "Backup: failed to open source {}", fmt::UTF(from.u8string()));
return;
}
const u64 size = src.GetSize();
std::vector<u8> buf(size);
if (size > 0) {
src.ReadRaw<u8>(buf.data(), size);
}
src.Close();
Common::FS::IOFile dst{to, Common::FS::FileAccessMode::Create, Common::FS::FileType::BinaryFile,
Common::FS::FileShareFlag::ShareReadWrite};
if (!dst.IsOpen()) {
LOG_ERROR(Lib_SaveData, "Backup: failed to open destination {}", fmt::UTF(to.u8string()));
return;
}
if (size > 0) {
dst.WriteRaw<u8>(buf.data(), size);
}
dst.Close();
}
static std::jthread g_backup_thread;
static std::counting_semaphore g_backup_thread_semaphore{0};
@ -64,7 +100,7 @@ static void backup(const std::filesystem::path& dir_name) {
fs::create_directory(backup_dir_tmp);
for (const auto& file : backup_files) {
fs::copy(file, backup_dir_tmp / file.filename(), fs::copy_options::recursive);
CopyShareReadWrite(file, backup_dir_tmp / file.filename());
current_count++;
g_backup_progress = current_count * 100 / total_count;
}