dahjah/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-02-18 14:26:31 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
5440c7737f
dolphin/Source
History
JosJuice 5440c7737f Explicitly transfer control of SYSCONF to emulated system 
The functions SaveToSYSCONF and LoadFromSYSCONF contain checks for
whether emulation is running. The intent of this is that when we're
emulating a Wii, the emulated system may write to SYSCONF whenever it
likes and does not expect anything else to write to SYSCONF, so the
host code shouldn't access SYSCONF while emulation is ongoing. However,
Core::IsRunning is an imperfect proxy for whether we've handed over
control of SYSCONF to the emulated system yet, as the actual handover
happens at a slightly different point in time than when the emulation
state is changed. This usually isn't a problem, but in theory it could
be a determinism problem if a setting is changed right as emulation is
starting, or it could cause the emulated software to briefly misbehave
if a setting is changed right as emulation is stopping.

Things got worse in 72cf2bdb87 when I
replaced the Core::IsRunning calls with !Core::IsUninitialized. With
IsRunning, there was be a period of time where SYSCONF should have been
protected but wasn't. With !IsUninitialized, there was a period of time
where SYSCONF shouldn't have been protected but was, and crucially, this
period of time included the moments where we do setup and teardown of
the emulated NAND, which broke transferring SYSCONF settings between the
host and the guest. 72cf2bdb87 was
reverted because of this.

This commit adds a flag that we explicitly flip when control is handed
over to or from the emulated system. This protects the SYSCONF file
for exactly as long as is needed.
2026-02-14 10:05:27 +01:00
..
Android Explicitly transfer control of SYSCONF to emulated system 2026-02-14 10:05:27 +01:00
Core Explicitly transfer control of SYSCONF to emulated system 2026-02-14 10:05:27 +01:00
DSPSpy Fix various typos and spelling mistakes 2026-01-17 20:11:38 +01:00
DSPTool Host: Remove unnecessary functions 2025-08-03 13:19:30 -07:00
PCH Fix various typos and spelling mistakes 2026-01-17 20:11:38 +01:00
UnitTests Merge pull request #13768 from JosJuice/page-table-fastmem-2 2026-02-04 16:20:35 -05:00
VSProps Make WIL a submodule and update it 2026-01-21 19:51:45 +01:00
.clang-format Clang-format: Fix invalid settings 2025-05-01 22:05:07 +02:00
CMakeLists.txt Merge pull request #14251 from JoshuaVandaele/cmake-editorconfig 2026-01-11 16:28:03 -05:00
dolphin-emu.sln Core/HW: Add Visual Studio project files for cpp-ipc library. 2025-10-28 18:50:58 +00:00