dahjah/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2026-02-18 22:37:42 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
5440c7737f
dolphin/Source/Core
History
JosJuice 5440c7737f Explicitly transfer control of SYSCONF to emulated system 
The functions SaveToSYSCONF and LoadFromSYSCONF contain checks for
whether emulation is running. The intent of this is that when we're
emulating a Wii, the emulated system may write to SYSCONF whenever it
likes and does not expect anything else to write to SYSCONF, so the
host code shouldn't access SYSCONF while emulation is ongoing. However,
Core::IsRunning is an imperfect proxy for whether we've handed over
control of SYSCONF to the emulated system yet, as the actual handover
happens at a slightly different point in time than when the emulation
state is changed. This usually isn't a problem, but in theory it could
be a determinism problem if a setting is changed right as emulation is
starting, or it could cause the emulated software to briefly misbehave
if a setting is changed right as emulation is stopping.

Things got worse in 72cf2bdb87 when I
replaced the Core::IsRunning calls with !Core::IsUninitialized. With
IsRunning, there was be a period of time where SYSCONF should have been
protected but wasn't. With !IsUninitialized, there was a period of time
where SYSCONF shouldn't have been protected but was, and crucially, this
period of time included the moments where we do setup and teardown of
the emulated NAND, which broke transferring SYSCONF settings between the
host and the guest. 72cf2bdb87 was
reverted because of this.

This commit adds a flag that we explicitly flip when control is handed
over to or from the emulated system. This protects the SYSCONF file
for exactly as long as is needed.
2026-02-14 10:05:27 +01:00
..
AudioCommon feat: Add an option to preserve audio pitch when emulation speed changes, integrating it into core configuration and both Qt and Android UIs. 2026-01-27 18:48:22 -05:00
Common Merge pull request #13768 from JosJuice/page-table-fastmem-2 2026-02-04 16:20:35 -05:00
Core Explicitly transfer control of SYSCONF to emulated system 2026-02-14 10:05:27 +01:00
DiscIO RiivolutionParser: Fix XML Param Parsing 2026-02-06 18:06:27 +01:00
DolphinNoGUI Merge pull request #14214 from JoshuaVandaele/cmake-nonbreaking-improvements 2026-01-25 18:33:46 -08:00
DolphinQt WiiSpeakWindow: Add missing Dolphin icon 2026-02-06 16:31:09 +04:00
DolphinTool Merge pull request #14214 from JoshuaVandaele/cmake-nonbreaking-improvements 2026-01-25 18:33:46 -08:00
InputCommon InputConfig: Remove unused local variables 2026-01-26 11:36:42 -08:00
MacUpdater Merge pull request #14036 from TellowKrinkle/SkipPostprocess 2026-01-25 22:01:29 -05:00
UICommon Merge pull request #13594 from jordan-woyak/state-cleanups 2026-02-03 16:50:52 -06:00
UpdaterCommon Fix various typos and spelling mistakes 2026-01-17 20:11:38 +01:00
VideoBackends Merge pull request #14302 from oltolm/opengl_assert 2026-01-25 21:06:57 -05:00
VideoCommon Merge pull request #14204 from Geotale/update-comment 2026-01-31 15:02:09 -08:00
WinUpdater AudioCommon / VideoBackends / WinUpdater - cleanup WRL code 2025-11-22 01:23:39 +01:00
CMakeLists.txt
DolphinLib.ARM64.props
DolphinLib.props Common: Add TransferableSharedMutex class and unit tests. 2026-01-19 21:56:59 -06:00
DolphinLib.vcxproj
DolphinLib.vcxproj.user
DolphinLib.x64.props
VersionInfo.plist.in